[MPlayer-dev-eng] a52 codec with divx causing segfault in mplayer

[Reimar Döffinger]

Hi,
On Tue, Aug 09, 2005 at 08:45:01PM +0200, Aurelien Jacobs wrote:
> I wasn't able to reproduce the problem but I think the attached patch
> could fix it.
> Could you please test this patch ?
> 
> Aurel
> Index: imdct.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/liba52/imdct.c,v
> retrieving revision 1.28
> diff -u -r1.28 imdct.c
> --- imdct.c	5 Aug 2005 13:33:49 -0000	1.28
> +++ imdct.c	9 Aug 2005 11:46:06 -0000
> @@ -813,7 +813,7 @@
>  		"sub $16, %%"REG_D"			\n\t"
>  		"jnc 1b				 	\n\t"
>  		"pop %%"REG_BP"				\n\t"//no we didnt touch ebp *g*
> -		:: "r" (data), "r" (buf)
> +		:: "b" (data), "c" (buf)
>  		: "%"REG_S, "%"REG_D, "%"REG_a, "%"REG_d

Hmm... well I guess the real problem here is the (IMHO) broken way to
use REG_BP without gcc knowing about it... Can somebody elaborate why it
was done like that (push + pop instead of putting it into the clobber
list)?

Greetings,
Reimar Döffinger