[MPlayer-dev-eng] [PATCH] CQMs in x264

Robert Swain robert.swain at gmail.com
Sat Aug 6 23:22:35 CEST 2005


Hello,
On 8/1/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> The patch contains DOS-linebreaks.

That's probably my fault as I hand editted the diff because I missed
something out. I'll avoid doing so again.

> I am also strogly opposed to that macro, most of it can go into the
> parse_cqm function, and writing the different error messages four time
> really is not that much code/work...

I have been informed by Loren that the macro was only intended to
decrease verbosity and that he agrees with you. Looking at it myself
though, I have no clue of the best way to approach this suggestion. I
have very little experience in C and it's showing. :( Could you offer
a more detailed suggestion of what to include within the parse_cqm
function?

Regards,
Robert Swain (superdump)




More information about the MPlayer-dev-eng mailing list