[MPlayer-dev-eng] [PATCH] [RFC] Demuxer cleanup

[Oded Shimon]

On Fri, Aug 05, 2005 at 05:22:02PM +0300, Oded Shimon wrote:
> On Fri, Aug 05, 2005 at 04:15:34PM +0300, Oded Shimon wrote:
> > On Mon, Aug 01, 2005 at 12:06:59AM +0200, Roberto Togni wrote:
> > > New patch attached.
> > > 
> > > Ciao,
> > >  Roberto
> > 
> > You messed up xmms:
> > > -int demux_xmms_open(demuxer_t* demuxer) {
> > > +static int demux_xmms_open(demuxer_t* demuxer) {
> > 
> > > +  demux_open_xmms,
> > 
> > Doesn't compile.
> 
> It get's worse. :)
> 
> > -#ifdef STREAMING_LIVE_DOT_COM
> > -    case DEMUXER_TYPE_RTP:
> > -      demux_close_rtp(demuxer); break;
> > -#endif
> > +  &demuxer_desc_rtp,
> 
> libmpdemux/libmpdemux.a(demuxer.o)(.data+0x84):libmpdemux/demuxer.c:193:
> undefined reference to `demuxer_desc_rtp'

Other than that, wanted to report that tv:// works just fine, and mention 
one last thing - there's no need to pollute the 'extern' decleration with 
#ifdef . They do nothing if they are invalid. Just the array definition is 
important...

Sorry for so many replies. :)

- ods15