[MPlayer-dev-eng] [PATCH] Fix return types of libvo API

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Aug 1 11:42:44 CEST 2005


Hi,
On Sun, Jul 31, 2005 at 11:13:17PM -0400, Rich Felker wrote:
> It's wrong because of the signed/unsigned mismatch. Returning -1 from
> a function with unsigned return type is broken.

Actually IMHO it is just a less ugly way of writing ~0, but like I said
it is disputable :-)
I guess the reason why it was uin32_t is maybe that somebody wanted the
functions to return flags, but since they don't I am (as said before) in
support of this patch.


Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list