[MPlayer-dev-eng] PATCH to support theora-exp in mplayer

Rich Felker dalias at aerifal.cx
Sat Apr 30 20:27:18 CEST 2005


On Sat, Apr 30, 2005 at 12:22:44PM -0400, Timothy B. Terriberry wrote:
> +       /* Read all header packets, pass them to theora_decode_header. */
> +       for (i = 0; i < THEORA_NUM_HEADER_PACKETS; i++)
> +       {
> +          op.bytes = ds_get_packet (sh->ds, &op.packet);
> +          op.b_o_s = 1;
> +          if ( (errorCode = theora_decode_headerin (&context->inf, &context->cc, &ts, &op))<0 )
> +          {
> +            mp_msg(MSGT_DECAUDIO, MSGL_ERR, "Broken Theora header; errorCode=%i!\n", errorCode);
> +            break;
> +          }
> +       }

These must be read from the demuxer's extradata, not ds_get_packet. If
the demuxer currently outputs them as packets, it needs to be fixed.
But otherwise your theora decoder model will only work with theora
stored in ogg (a very broken format) and nothing else.

Rich




More information about the MPlayer-dev-eng mailing list