[MPlayer-dev-eng] [PATCH] GGI driver update

[Reimar Döffinger]

Hi,
On Sat, Apr 30, 2005 at 05:40:14PM +0200, Christoph Egger wrote:
> > On Sat, Apr 30, 2005 at 11:39:17AM +0200, Christoph Egger wrote:
> > > 
> > > The patch consists of two parts. The first part touches configure,
> > > the second libvo/vo_ggi.c.
> > 
> > You have a few printf calls in there, please use mp_msg instead.
> 
> hmm... But they are deactivated. So if they still disturb you,
> just remove them.

I can't see any sense in that. Obviously they have some debugging value,
then why can't you just make them mp_msg calls so that you can enable
them without hacking the source (unless maybe if they are in a _really_
performance critical path).

Greetings,
Reimar Döffinger