[MPlayer-dev-eng] PATCH to support theora-exp in mplayer

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Sat Apr 23 00:03:33 CEST 2005


Rich Felker wrote:
> On Fri, Apr 22, 2005 at 05:06:01PM -0400, Timothy B. Terriberry wrote:
> 
>>>Flip is deprecated and must not be used anymore. Instead use negative
>>>strides if your codec outputs upside-down pictures.
>>
>>The problem is this: the library outputs right-side up pictures, but
>>they are decoded from bottom to top, as this is how they are stored in
> 
> 
> This is a very ugly hack..
> 
> 
>>the bitstream. However, mplayer's filters (most notably vf_scale) do not
>>handle slice rendering unless it is done from top to bottom. So the
> 
> 
> vf_scale is the only such filter, and it's broken. Actually filters
> are not allowed to make any assumptions about the order/shape of
> slices, but vf_scale does because it's broken. Someone should fix it.

At a first glance, there are still some wrong uses of memcpy in
swscaler, they definitely need to be fixed.

-- 
Jindrich Makovicka




More information about the MPlayer-dev-eng mailing list