[MPlayer-dev-eng] -z is not a portable linker option

[Rich Felker]

On Wed, Apr 20, 2005 at 08:27:17PM -0700, Steven M. Schultz wrote:
> Hi -
> 
> 	An unconditional "-Wl,-z" was added to the Makefile and that's causing
> 	a problem building MPlayer on OSX:
> 
> cc -I../libvo -I../../libvo -I/usr/X11R6/include -O4 -mcpu=970 -mtune=970 -faltivec -pipe -ffast-math -fomit-frame-pointer -DSYS_DARWIN -DCONFIG_DARWIN -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I. -I/usr/X11R6/include -I/usr/X11R6/include/freetype2   -I/usr/local/include/SDL -D_THREAD_SAFE -I/usr/X11R6/include    -I/usr/local/include     -Wl,-z,noexecstack -o mplayer mplayer.o mp_msg.o cpudetect.o codec-cfg.o spudec.o playtree.o playtreeparser.o asxparser.o vobsub.o subreader.o sub_cc.o find_sub.o m_config.o m_option.o parser-cfg.o m_struct.o edl.o unrarlib.o mixer.o parser-mpcmd.o subopt-helper.o libvo/libvo.a libao2/libao2.a    libmpcodecs/libmpcodecs.a   libaf/libaf.a libmpdemux/libmpdemux.a input/libinput.a postproc/libswscale.a osdep/libosdep.a -Llibmpdvdkit2 -lmpdvdkit libavcodec/libavcodec.a libavformat/libavformat.a  -lmad -ldv -ltheora -logg -lfaad -llzo -lmp3lame  -lxvidcore -lm  -lpng -lz -lz -ljpeg    -L/usr/X11R6/lib -lfreetype -ltinfo  /usr/local/src/live/li!
>  veMedia/libliveMedia.a /usr/local/src/live/groupsock/libgroupsock.a /usr/local/src/live/UsageEnvironment/libUsageEnvironment.a /usr/local/src/live/BasicUsageEnvironment/libBasicUsageEnvironment.a -lstdc++     -framework Carbon -framework QuickTime -framework CoreAudio   -L/usr/local/lib -lfontconfig    mp3lib/libMP3.a liba52/liba52.a libmpeg2/libmpeg2.a tremor/libvorbisidec.a   -lGL  -lXv  -lXxf86vm -lXinerama -L/usr/X11R6/lib -lXext -lX11   -L/usr/local/lib -lSDLmain -lSDL -Wl,-framework -Wl,Cocoa -Wl,-framework -Wl,OpenGL                 -liconv -lintl -lm
> ld: unknown flag: -z
> gmake: *** [mplayer] Error 1
> 
> 	I'll manually edit the makefile to work around the problem for the
> 	short term but a better long term solution would be to conditionalize
> 	the use of "-Wl,-z..."

I've reversed it for now. It should be detected by configure if this
nonsense is needed for anything, but I don't understand why it should
be needed anyway...

Rich