[MPlayer-dev-eng] [PATCH] unrarlib on AMD64

Sun Apr 17 16:37:32 CEST 2005

On Sunday, 17 April 2005 at 11:37, Jindrich Makovicka wrote:
> Rich Felker wrote:
> >>diff -Naur MPlayer-20050416/unrarlib.h MPlayer-20050416-patched/unrarlib.h
> >>--- MPlayer-20050416/unrarlib.h 2005-04-15 20:48:03.000000000 +0200
> >>+++ MPlayer-20050416-patched/unrarlib.h 2005-04-16 18:17:38.000000000 +0200
> >>@@ -97,13 +97,13 @@
> >> #ifdef _WIN_32
> >> typedef unsigned char    UBYTE;             /* WIN32 definitions            */
> >> typedef unsigned short   UWORD;
> >>-typedef unsigned long    UDWORD;
> >>+typedef unsigned int    UDWORD;
> >> #endif
> >>
> >> #ifdef _UNIX                                /* LINUX/UNIX definitions       */
> >> typedef unsigned char    UBYTE;
> >> typedef unsigned short   UWORD;
> >>-typedef unsigned long    UDWORD;
> >>+typedef unsigned int    UDWORD;
> >> #endif
> > 
> > 
> > The correct solution is:
> > typedef uint32_t UDWORD;
> 
> What about adding an (optional) support for rar executable, instead of
> unrarlib? Recent rars cannot be read by unrarlib anyway.

Because we strive not to require proprietary libs/tools. Though unrar
source is available, the license is not GPL compatible. No rar3 support
is planned in unrarlib, so we just have to live with it or write rar3
decompression routines ourselves.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"