[MPlayer-dev-eng] PATCH: processing "file:///" URL

[Eugene Crosser]

Ismail Donmez wrote:
> On Thursday 14 April 2005 19:45, Eugene Crosser wrote:
>
>>+       if (strcmp(url->protocol, "file")==0){
>>+               char *unescfilename = strdup(url->file);
>>+               url_unescape_string(unescfilename,url->file);
>>+               return open_stream_full(unescfilename,STREAM_READ,
>>+                                               options,file_format);
>>+       }
>
>
> You don't free unescfilename anywhere so this code leaks.

That's right.  But it happens only once per run, so this should not be a
problem.  Besides that, as far as I could tell, other existing code that
deals with URLs have similar leaks.

I can redo the patch if you people think it is really necessary.

Eugene
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050415/3f2708fe/attachment.pgp>