[MPlayer-dev-eng] [PATCH] "verbose" in libmpcodecs/pullup.c

D Richard Felker III dalias at aerifal.cx
Fri Apr 1 04:27:18 CEST 2005


On Thu, Mar 31, 2005 at 02:44:14PM -0500, Yue Shi Lai wrote:
> Hi,
> 
> The line that checks the global variable "verbose" is implemented wrong 
> in libmpcodecs/pullup.c. The fact that "verbose" is a _signed_ variable 
> is disregarded, which results in the undesired increasing verbosity with 
> a negative value.

it's not implemented wrong; verbose is a boolean flag. the way the
field is declared is irrelevant. if you want to document the api for
pullup.c, feel free.. for now it's undocumented. :)

rich




More information about the MPlayer-dev-eng mailing list