[MPlayer-dev-eng] [PATCH] printf --> mp_msg transition (mplayer.c)

The Wanderer inverseparadox at comcast.net
Wed Sep 29 10:25:04 CEST 2004


Having this time confirmed first that the changed version *does*
compile, and that the patch isn't obviously flawed so far as I can tell
(if I've managed to attach the correct version...), here I go again.


The attached patch does several things:

Moves all (apparently) translation-appropriate messages from mplayer.c
to help/help_mp-en.h.

Moves one message from help/help_mp-en.h back to mencoder.c, because it
should not have been moved in the first place.

Changes all functional printf calls in mplayer.c to FIXME'd mp_msg
calls.

Adds trailing periods to a few strings; may also correct a few spelling
errors, but I don't think I left anything like that in this version of
the patch.


Also, a question in light of the fact that messages of MSGL_V and above
shouldn't be moved to the translations file (copied from my last
submission, because in the confusion of my cola it wasn't answered).

There are two MSGTRs of MSGL_V (AODescription_AOAuthor, AOComment) in
mplayer.c which were present before I did my work; for the moment, I've
left them alone. If I come across such things, which I would not
ordinarily change but which are inconsistent with the rules I'm
following, should I correct them as well?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer.c_printfs.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040929/36dd0f69/attachment.txt>


More information about the MPlayer-dev-eng mailing list