[MPlayer-dev-eng] [PATCH] x264 option renaming
lorenm at u.washington.edu
Wed Sep 29 02:28:51 CEST 2004
On Mon, 27 Sep 2004, Ivan Kalvachev wrote:
> I have removed the variable change name, because:
> 1. the local variable names are the same as the one used in x264 structure.
> 2. it is considered cosmetic change and violate the MPlayer rules.
No problem. Just that the first time I submitted the patch,
On Sat, 25 Sep 2004, Diego Biurrun wrote:
> IMO (others may disagree) you should rename the variables as well,
> having variable names and option names differ is a recipe for code
> obfuscation IMO.
... and I took it as a suggestion.
> BTW have you tested 3 pass encoding?
I have tested that it works. I haven't tested how much it helps as
compared to 2-pass.
The implementation is essentially identical to my 3-pass encoding for
lavc, so the gains should also be similar. But if it doesn't help, it's
due to my lack of tuning of the multipass mode in general (which I'm
trying to remedy), not something specific to 3-pass.
More information about the MPlayer-dev-eng