[MPlayer-dev-eng] Documentation bug re win32 codecs

[Mr Allwyn Fernandes]

Hi all, 

I've created a patch for the issue described here
http://mplayerhq.hu/pipermail/mplayer-users/2004-September/048013.html

This patch does several things: 
* updates configure to add /usr/local/lib/codecs into the search path for 
Win32, Xanim, and RealPlayer libraries, to match the documentation.
* Changes the configure error message when Win32 codecs are not found.
* updates DOCS/xml/*/install.html changing the references 
'/usr/local/lib/codecs' to '$PREFIX/lib/codecs' and '/usr/local/etc/mplayer' 
to '$PREFIX/etc/mplayer'
* updates README making a similar change to the one above.

This patch does NOT change the references to /usr/local/lib/codecs in 
DOCS/xml/*/codecs.html, because those explicitly state that that is the 
DEFAULT install directory. (However, since this directory is now always 
checked, this is a non-issue.)

I'm not subscribed to the list, so please CC me in on any feedback to this 
patch.

Cheers,

Allwyn.

----------  Forwarded Message  ----------

Subject: Re: Documentation bug re win32 codecs
Date: Sunday 26 September 2004 08:18
From: Mr Allwyn Fernandes <mhu at stobor.net>
To: mplayer-users at mplayerhq.hu

Hi Dominik,

I finally got some time, and thought to follow this up. Found your reply in
the archives. See responses below. Please copy me in on any other feedback -
I am not subscribed to this list. Thanks.

On Thu Sep 2 12:24:24 CEST 2004, Dominik 'Rathann' Mierzejewski wrote:
> On Thursday, 02 September 2004 at 06:09, Mr Allwyn Fernandes wrote:
>> Hi all,
>>
>> I just grabbed MPlayer 1.0pre5, and was trying to install it from
>> source on
>> linux. I stumbled across a minor documentation bug trying to install the
>> Win32 codecs. (I've figured it out, so there's no need for help with
>> it, but
>>
>> When I then run "configure --prefix=/usr/mplayer/1.0pre5"
>
>Why do you use such strange non-standard paths?

Simple: version flexibility.

I can try out /usr/mplayer/1.0pre5/bin/mplayer to see if it works, without
deleting /usr/mplayer/0.99/bin/mplayer just to do so. New bugfix in CVS, but
mencoder has not caught up, and is now broken? No probs - run
/usr/mplayer/cvs/bin/mplayer but use /usr/mplayer/1.0pre5/bin/mencoder.
It may happen (it does with some pieces of software, tho this is my first
 play with mplayer) that features disappear/break between versions. When I'm
 comfortable with the new version, the old one can be removed without
 breaking anything.

To make life easy, /usr/mplayer/current is a symlink to /usr/mplayer/1.0pre5,
and all /usr/*/current/bin are in my $PATH. Trying out something, but I don't
want it in $PATH?  Just don't symlink it.

I started doing this because I do development myself, and switching between
versions, even of your team's own code, can be a nightmare if everything
chooses to write over the same directory.


Having said all that, the problem is the same regardless of which standard or
non-standard path you choose, even /usr - only using the default /usr/local
works as advertised.

>>   Failed to find a Win32 codecs directory! (default:
>>   /usr/local/lib/codecs/)
>>   Create it and copy the DLL files there! You can download the codecs
>>   from our
>>   homepage at http://www.mplayerhq.hu/MPlayer/releases/codecs/
>>
>> So I get to this stage and I am wondering what's going on... Somewhat
>> surprisingly, "configure --prefix=/usr/mplayer/1.0pre5
>> --with-win32libdir=/usr/local/lib/codecs" seems to work - win32
>> codecs are
>> listed as enabled!
>>
>> It turns out that the configure script, line 5003 looks for win32
>> codecs in
>> "$_libdir/codecs" "$_libdir/win32" /usr/local/lib/win32 /usr/lib/win32,
>> and not in /usr/local/lib/codecs as advertised.
>
>You're right. How about creating a patch and sending it to mplayer-dev-eng?
>
>R.
>
>--
>MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/
>"I am Grey. I stand between the candle and the star. We are Grey.
> We stand between the darkness ... and the light."
>        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"

Finally got some time - I'm submitting one shortly.

Cheers,

Allwyn.

--
Allwyn Fernandes
Director
Stobor Pty Ltd

Mobile: + 61 414 470 392
Email: af at stobor.net

-------------------------------------------------------

-- 
Allwyn Fernandes
Director
Stobor Pty Ltd

Mobile: + 61 414 470 392
Email: af at stobor.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure_documentation.diff
Type: text/x-diff
Size: 10321 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040926/b1a0aa3c/attachment.diff>