[MPlayer-dev-eng] [PATCH] change include paths (Was: Re: [PATCH] libvo/vo_yuv4mpeg.c mp_msg API conversion)

Diego Biurrun diego at biurrun.de
Sun Sep 26 00:49:58 CEST 2004


Sebastian Hegler writes:
> Diego Biurrun wrote:
> >> #include "fastmemcpy.h" 
>  >> -#include "../postproc/rgb2rgb.h"
>  >> -#include "../libmpcodecs/vf_scale.h"
>  >> +#include "postproc/rgb2rgb.h"
> >> +#include "libmpcodecs/vf_scale.h"
> > This change is unrelated to the mp_msg transition, it is not a bad 
> > idea, since -I.. is in the CFLAGS anyway, but it should be in a 
> > separate patch and then probably be done for all of libvo/.
> Attached.

Please always test compilation of your patches:

silver:/usr/src/mplayer/dev$ make
cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -g -O4 -march=k6-3 -mcpu=k6-3 -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -Ilibmpdemux -Iloader -Ilibvo -I/usr/include/freetype2 -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include  -I/usr/include/SDL -D_REENTRANT -I/usr/X11R6/include     -I/usr/include/  -o mplayer.o mplayer.c
In file included from libvo/video_out.h:17,
                 from mplayer.c:51:
libvo/img_format.h:2:36: libmpcodecs/img_format.h: No such file or directory
In file included from mplayer.c:54:
libvo/sub.h:59:23: subreader.h: No such file or directory
make: *** [mplayer.o] Error 1

Patch rejected.  Fix this and resend.

Diego




More information about the MPlayer-dev-eng mailing list