[MPlayer-dev-eng] XviD 1.1.x support

[Guillaume POIRIER]

Hi,
Le ven 24/09/2004 à 22:48, Diego Biurrun a écrit :
> Guillaume POIRIER writes:
> > On Wed, 1 Sep 2004 XviD devs issued updated MPlayer/MEncoder's frontend
> > for their new 1.1 branch.
> > I've been using/testing it quite a lot since then, and it works fine
> > with me.
> 
> Ivan, could you review this?

Yes, Please Ivan!! ;-)
Attached patch includes updated manpage and unmodified front-end.


> > +The following option is only available in cvs development versions
> 
> CVS
> 
> I'd either say "CVS versions" or "development versions".

I chose "development versions"


> > +.B bvhq=<0|1>
> > +This setting allows vector candidats for B frames to be used for
> 
> candidatEs

done.


> > +the coding chosen using a rate distortion optimized operator,
> > +which is what is done for P frames by the vhq option.
> 
> I don't understand what "the coding chosen" is supposed to mean.
> Should it be "encoding" instead of "coding"?

Yeah, it's encoding.

> > +This produces nicer-looking B frames while having almost no
> > +performance penalty.
> 
> I'd say "incurring" instead of "having".

Done.


> > +
> > +.
> > +.
> 
> Don't add empty lines to the man page.

Can somebody tell me why I keep doing dumb things like this? ;-)


> > @@ -53,6 +59,8 @@
> >  	{ "filmeffect", &filmeffect, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> >  	{ "deblock-luma", &lumadeblock, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> >  	{ "deblock-chroma", &chromadeblock, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> > +	{ "dering-luma", &lumadering, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> > +	{ "dering-chroma", &chromadering, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> 
> Where is the documentation for these? ;-)

I was hoping nobody would notice... ;-)
Done, but I kinda had to re-work xvid decoder section. Please have a
look at it.

Cheers,
Guillaume

-- 
The Biscuit :
"A biscuit has no spirit, it's just a biscuit.
 But, it used to be milk, eggs, etc... And in eggs, there's potential
life!
 JC Van Damme
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvid-1.1-round2.patch
Type: text/x-patch
Size: 42967 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040925/9412800e/attachment.bin>