[MPlayer-dev-eng] [PATCH] fix audio decoding after my last patch

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Sep 21 22:47:15 CEST 2004


Hi,

applied it.

>>the attached patch should make audio decoding work again in most cases. 
>>Reason for the problems was that e.g. demux_mkv.c sometimes set 
>>samplesize to 0.
> 
> Yeah, I've fixed that a few hours ago for demux_mkv.c. But other
> demuxers might suffer from that, too, so it's probably better to set it
> in the ads.

Actually the best solution would be setting it in the ad_* but also 
having the demuxers set it, except when they don't know it in which case 
they should set it to 0.
Anyone volunteering to clean this up a bit? The ad_* should also set 
sh_audio->sample_format correctly. This is currently no problem as the 
demuxers don't modify that, but it isn't a clean way to do it IMO..

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list