[MPlayer-dev-eng] patch for set right aspect ratio on playing with "-fs -vo vesa"

Sascha Sommer saschasommer at freenet.de
Tue Sep 21 14:12:08 CEST 2004


On Sunday 19 September 2004 06:47, Attila Kinali wrote:
> On Thu, Jul 22, 2004 at 10:19:34AM +0300, Alexander Buloichik wrote:
> > Index: vo_vesa.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/libvo/vo_vesa.c,v
> > retrieving revision 1.100
> > diff -u -r1.100 vo_vesa.c
> > --- vo_vesa.c	25 Jun 2004 17:29:18 -0000	1.100
> > +++ vo_vesa.c	22 Jul 2004 07:16:08 -0000
> > @@ -803,6 +803,11 @@
> >  		      {
> >  			dstW = video_mode_info.XResolution;
> >  			dstH = video_mode_info.YResolution;
> > +
> > +		        aspect_save_orig(width,height);
> > +			aspect_save_prescale(d_width,d_height);
> > +			aspect_save_screenres(video_mode_info.XResolution,video_mode_info.YRe
> >solution); +			aspect(&dstW,&dstH,A_ZOOM);
>
> Anyone out there who would like to maintain vo vesa ?
>

The one should also take into account that vo vesa can't scale without 
swscaler which gets activated with -zoom. In that case the nonvisible
part of this if else construction gets executed which does exactly the same 
thing as in the patch, but maybe this patch is for use with vidix in this
case maybe a simple

		if(use_scaler>1
#ifdef CONFIG_VIDIX
		|| vidix_name
#endif
		) 

would do? I'll commit this if noone complains.

Better would be to remove swscaler from vo vesa all together, as it is still 
used for conversion. Not speaking about the console hiding mess in vbelib.c

Sascha




More information about the MPlayer-dev-eng mailing list