[MPlayer-dev-eng] [PATCH] automatically insert vf_expand for displaying OSD

[D Richard Felker III]

On Sun, Sep 19, 2004 at 04:12:46PM +0900, Attila Kinali wrote:
> On Wed, Sep 15, 2004 at 11:35:53PM -0400, D Richard Felker III wrote:
> > > Ok...
> > > Then let's completely drop that issue.
> > > IMHO what needs to be done with the osd/sub code is, to remove it from
> > > the vo modules completely. There is no need to support it with each
> > > module if there is no HW accel. It should be IMHO either in vf.c or made
> > > as a seperate vf (which is autoloaded when the user requests subtitles).
> > 
> > not possible, it's hopelessly slow. with subtitle code in the vo
> > driver, it can blend directly into video memory. because the vf layer
> > sucks (actually it's very very hard to design a vf layer where this
> > would work) that can't be done with vf, so there'd be a ton of extra
> > copying for subtitles, and movies would be unplayable on my box!
> 
> I somewhat dont like this answer :)
> I thought that vf modules could selectively buffer strides or not.

you mean slices. but the problem is you can't know which ones to
buffer until osd drawing time, which is _after_ slice time. also this
is still slower than the current method, which just does a little bit
of reading from video memory (bad, slow!) and hopes that the osd text
is small enough not to require much reading.

> Do you have any other ideas how this could be done in a more or less
> fast way ?

unfortunately no.

rich