[MPlayer-dev-eng] [PATCH] autoselect alsa chunk_size

[Attila Kinali]

On Tue, Sep 14, 2004 at 12:44:35AM +0200, Aurelien Jacobs wrote:
> On Sat, 11 Sep 2004 18:51:48 +0900
> Attila Kinali <attila at kinali.ch> wrote:
> 
> > On Fri, Aug 27, 2004 at 01:27:06PM +0200, Aurelien Jacobs wrote:
> >  Here is the first one :
> > > Some sound cards don't support the default alsa chunk_size. This
> > > patch allow ao_alsa to automatically try the other chunk_size, so
> > > that the user don't need to explicitely set it on the commande line.
> > 
> > +            chunk_size = 512 + 1024 - chunk_size;
> > 
> > Where do these values come from ?
> > This needs to be documented (ie one line of comment)
> 
> I don't really know ;-)
> In fact the current ao_alsa code assign 512 or 1024 to chunk_size
> depending on the value of the -abs option (which the manpage
> document as obsolete and for oss only ! Should probably be
> updated but I don't really know how.)
> These values are not documented in the current code, so I can't
> document them myself. My code simply try the other value if
> the first one failed.

You should at least add a coment how you came up with these values
and why you add them up and substrakt the current chunk_size.


			Attila Kinali