[MPlayer-dev-eng] [PATCH] mixer index selection for alsa

[Diego Biurrun]

Reimar Döffinger writes:
> 
> Some minor revisions, I will apply on Monday or Tuesday if you don't 
> comment...

Just some nitpicks as usual.  Please fix them when you commit.

> +.I NOTE:  

trailing whitespace

> +ALSA mixer channel names followed by a number must be specified in the <name,number>

This line is too long.

> +format, i.e. a channel labled 'PCM 1' in alsamixer must be converted to

labeled

> -      if(mixer_channel) mix_name = mixer_channel;
> +      if(mixer_channel) {
> +	 char *test_mix_index;
> +
> +	 mix_name = strdup(mixer_channel);
> +	 if (test_mix_index = strchr(mix_name, ',')){
> +		*test_mix_index = 0;
> +		test_mix_index++;
> +		mix_index = strtol(test_mix_index, &test_mix_index, 0);

You're messing up indentation here.

> +      if (mixer_channel) {
> +	free(mix_name);
> +	mix_name = NULL;

same here.

Diego