[MPlayer-dev-eng] [PATCH] compilers "optimizing" pe_image too much

[Dominik 'Rathann' Mierzejewski]

On Thursday, 16 September 2004 at 22:39, Torinthiel wrote:
> On Thu, Sep 16, 2004 at 09:58:52PM +0200, Reimar Döffinger wrote:
> > Could someone test compilation on gcc 2.95 and other compilers? I tend 
> > to put those attributes always at the wrong place...
> 
> gcc 2.95.4
> Compiles fine, havent checked anything more.
> 
> But:
> In file included from pe_image.c:56:
> wine/debugtools.h:67: warning: useless keyword or type name in empty declaration
> wine/debugtools.h:67: warning: empty declaration

I've worked around this with:
--- MPlayer-20040731/loader/wine/debugtools.h.loader    Sat Feb 24 21:30:28 2001 
+++ MPlayer-20040731/loader/wine/debugtools.h   Sat Jul 31 18:55:28 2004 
@@ -63,11 +63,13 @@
 static inline LPCSTR debugstr_a( LPCSTR s )  { return debugstr_an( s, 80 ); }
 static inline LPCSTR debugstr_w( LPCWSTR s ) { return debugstr_wn( s, 80 ); }
 
+#ifndef dbg_printf 
 #ifdef __GNUC__
 extern int dbg_printf(const char *format, ...) __attribute__((format (printf,1,2)));
 #else
 extern int dbg_printf(const char *format, ...);
 #endif
+#endif 
 
 #define TRACE_(X) TRACE
 #define WARN_(X) TRACE

It's been in my patchset for some time now, but I haven't gotten around to
sending it here yet.

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"