[MPlayer-dev-eng] [PATCH] automatically insert vf_expand for displaying OSD

[D Richard Felker III]

On Thu, Sep 16, 2004 at 10:49:03AM +0900, Attila Kinali wrote:
> On Sat, Sep 04, 2004 at 10:49:54AM +0200, Reimar Döffinger wrote:
>  
> > hw acceleration? at least vo_x11, vo_xv, vo_vesa, vo_quartz, vo_fbdev, 
> > vo_gl2, ... (probably all?) don't use any hardware acceleration, 
> > although they avoid one memcpy by writing it directly into the output 
> > buffers, as far as I understand the code (but gl2 doesn't have seperate 
> > output buffers, which causes bug #55).
> 
> Ok...
> Then let's completely drop that issue.
> IMHO what needs to be done with the osd/sub code is, to remove it from
> the vo modules completely. There is no need to support it with each
> module if there is no HW accel. It should be IMHO either in vf.c or made
> as a seperate vf (which is autoloaded when the user requests subtitles).

not possible, it's hopelessly slow. with subtitle code in the vo
driver, it can blend directly into video memory. because the vf layer
sucks (actually it's very very hard to design a vf layer where this
would work) that can't be done with vf, so there'd be a ton of extra
copying for subtitles, and movies would be unplayable on my box!

> Then the osd code of mplayer.c should go into a seperate file.
> It just blows up main() and thus obfuscates it.
> And IMHO subreader.c should be split up into several files, one
> for each format. Maybe a libsubreader/ dir would be good.
> 
> Then it would be easier to redesign the whole subsystem (which is
> needed as we are hitting its limitations).
> 
> Any volunteers to do that ? :)

arpi in g2
me in g3 ;)

in g1? nobody..

rich