[MPlayer-dev-eng] (was: Status of a patch) -> -sub and -sid broken

Joey Parrish joey at nicewarrior.org
Wed Sep 15 21:12:41 CEST 2004


On Wed, Sep 15, 2004 at 09:18:21AM +0200, Moritz Bunkus wrote:
> > Joey, since it was your commit that broke it you should take care of
> > this and either fix it or revert your commit (not cvs admin -o).
> 
> If you're talking about the 'switch subtitles and display their
> language' patch then do not commit a reverted patch because it would
> immediately break the stuff I committed on top of it for Matroska. In
> this case the issue should be fixed and not just reverted.
> 
> If it's something else then just ignore me :)

No, we're talking about the patch on which that one is based... :(
So it's even worse.  I can't revert without reverting the improvements
to it that you and I have made since.

I will fix this, but I haven't figured out how to do it correctly (yet).

I apologize, and please give me some time until my real life calms down
a little bit.

(And until then, other people's fixes are WELCOME.)

--Joey

-- 
"Of the seven dwarves, the only one who shaved was Dopey.
That should tell us something about the wisdom of shaving."




More information about the MPlayer-dev-eng mailing list