[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc), third patches

[The Wanderer]

Ivo wrote:

> Sorry to step in, but I think I have something useful to say about
> this :-)

Agreed, you did.

> On Monday 13 September 2004 15:04, The Wanderer wrote:
> 
>> Actually I was doing this intentionally, because A) I've seen
>> several/many others do it the same way, B) that seems most of the
>> time to be how they're committed (multiple CVS-log messages with
>> the same description but one file per message, rather than many
>> files and just one message),
> 
> The reason this occurs is if a developper does:
> 
> cvs -z3 commit somedir/file1 someotherdir/file2 somedir/file3
> 
> an editor (usualy vi) pops up and the cvslog message is written.
> After that, the cvs server applies the patches to all files specified
> and for each file an e-mail is sent with the same cvslog message.

Right; that makes sense. I've never used CVS from the other end, and my
man-page interface is just ugly, so I don't do as much in-depth
documentation reading as I used to.

>> and C) it makes it much easier for me to re-create the patch if
>> some part of it (say, just one file's worth) needs to be changed;
>> rather than having to
>> 
>> diff -u main/file1.c main.working/file1.c > patch.diff && diff -u 
>> main/file2.c main.working/file2.c >> patch.diff && (...)
>> 
>> I'd just need to re-diff the single file.
> 
> You could also use cvs diff -u on your working directory. Like:
> 
> cd main.working
> cvs diff -u file1.c file2.c file3.c > ../cvsdiff-u.to.be.sent.to.dev-eng
> cd ..
> 
> It doesn't matter whether you changed only one file or more, it is
> always a complete up-to-date patch.

True, but a) I was (due in no small part to the horrible man-page thing
I mentioned) unaware that 'cvs diff' could accept options, since it
isn't the actual diff program but just a little thing within cvs, and b)
last time I tried that I somehow didn't think of specifying individual
files to be cvs diff'ed... I'm feeling utterly incompetent lately, don't
mind me.

In any case, thanks for the explanation and the suggestion.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.