[MPlayer-dev-eng] [PATCH] EDL fix harcoded translatable messages

[Diego Biurrun]

Reynaldo H. Verdejo Pinochet writes:
> On Mon, Sep 13, 2004 at 10:00:27AM +0200, Diego Biurrun wrote:
> > Reynaldo H. Verdejo Pinochet writes:
> > > 
> > > this patches fix those anoying harcoded translatable messages
> > > ( my dumb mystake ) on EDL you were talking about.
> > 
> > Fix the things I outline below and I will apply this.
> > 
> All fixed, spanish translation added, have added doxygen comments on 
> Attila's request and a missed free() on player_exit.

Please read what I just sent to dev-eng about splitting up patches and
follow the advice I give there.  I'm currently too lazy to handle this
split-up patch, besides, I could not resist to pick some more nits, so
the patch is refused for now, sorry.

Please send in an updated version, I'll apply.

> +/** 
> + *  we cant do -edl and -edlout at the same time
> + *  so we check that here.

We can't

> + *  \return EDL_ERROR on error and 1 otherwise
> + *  \brief Makes sure edl has been called correctly

EDL, same below

> +/** Calculates the total amount edl_records we will need
> + *  to hold the edl operations queue, we need one edl_record
> + *  for each SKIP and two for each MUTE.
> + *  \return total amount of needed edl entries, EDL_ERROR when can't read file

when file can't be read

> + *  \brief counts needed edl entries

Complete sentences should be capitalized and end in a period, same
above and below.

> +/** parses edl_filename to fill edl operations queue
> + *  \return No of edl records stored or EDL_ERROR when can't read from file

s/No/Number/, when file can't be read

No.

> +int edl_memory_slots = 0; /// No of EDL entries (1 for skip + 2 for each mute)
> +int edl_operations = 0; /// No of EDL operations, skip + mute

Same as above, either s/No/Number/ or write No., I prefer number.

> +int edl_mute_count = 0; /// even number when mute has been matched mute/unmute

I don't understand this comment.

> +#define MSGTR_EdlRecordsNo "Read %d EDL actions\n"

End in a period.

> +#define MSGTR_EdlOutOfMem "No hay memoria suficiente para almacenar los datos edl.\n"

EDL

> +#define MSGTR_EdlRecordsNo "Leidas %d acciones EDL.\n"

I'd say "Leido", but I trust your Spanish to be better than mine, so
keep it.

Diego