[MPlayer-dev-eng] Re: patch for vo_jpeg.c and vo_png.c
ivop at euronet.nl
Tue Sep 14 11:57:23 CEST 2004
On Sunday 12 September 2004 02:37, Attila Kinali wrote:
> On Thu, Aug 26, 2004 at 11:52:30PM +0200, Fredrik Axelsson wrote:
> > >Your patch does not match for 'outdir' and it does not parse all the
> > >other possible jpeg options. I could even type something like -vo
> > >jpeg:some-random-characters=<value> and it would use that value as the
> > >output directory. IMHO this patch should not be committed.
> > I have made a new patch which I hope is acceptable. It is only for
> > vo_png.c which lacks the outdir option. It should be easy to extend it
> > to parse future suboptions if neccessary.
> Ivo, any comments on this patch ?
Oops, totally forgot about this patch. Anyway, I think it's not good enough.
It's not a clean parser, it uses a lot of unnecessary temp variables all
over the place, it uses while loops inside the main while loop and also, it
adds an png_outdir variable which isn't used anywhere else in the code, so
it has no functionality. I'd say, don't commit.
More information about the MPlayer-dev-eng