[MPlayer-dev-eng] [PATCH] EDL fix harcoded translatable messages

[Diego Biurrun]

Reynaldo H. Verdejo Pinochet writes:
> 
> this patches fix those anoying harcoded translatable messages
> ( my dumb mystake ) on EDL you were talking about.

Fix the things I outline below and I will apply this.

> ps1: given Im doing some long term work trying to implement edl
> on mencoder too, and having prooved im not a cola addict ;) could
> you consider granting write cvs access?

I'm not opposed to this, what do the others say?

> ps2: I can send the spanish translation for this messages too, just
> want to know if this is the right thing to do, given there ARE spanish
> translators for this kind of messages.

It's not a crime to offload some work from the translators ;-).
You're welcome to provide translations for languages you know.

Para algo tienen que servir los idiomas ;-)


> --- edl.c	2004-09-04 04:37:12.000000000 -0400
> +++ ../my_main/edl.c	2004-09-12 22:35:59.000000000 -0400
> @@ -3,6 +3,8 @@
>  #include "config.h"
>  #include "mp_msg.h"
>  #include "edl.h"
> +#define HELP_MP_DEFINE_STATIC

What is this define for?

> +#include "help_mp.h"


> +                    mp_msg(MSGT_CPLAYER, MSGL_WARN, MSGTR_EdlBadlyFormatedLine,

Nit: "formatted".  Since you're redoing the patch anyway, you might as
well change this while you're going.

> +#define MSGTR_EdlCantUseBothModes "Cant use -edl and -edlout at the same time\n"
"Can't", you should end sentences in a period, same below.

> +#define MSGTR_EdlRecordsNo "Readed %d EDL actions\n"

"read"

> +#define MSGTR_EdlCantOpenForWrite "Error opening file [%s] for writing!\n"
> +#define MSGTR_EdlCantOpenForRead "Cant open EDL file '%s' for reading!\n"

IMHO no need for an exclamation mark.

> +#define MSGTR_EdlBadlyFormatedLine "Badly formated EDL line [%d] Discarding!\n"

"formatted"

Diego