[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc.), second patches

Attila Kinali attila at kinali.ch
Sat Sep 11 15:08:44 CEST 2004


On Sat, Aug 28, 2004 at 07:38:36PM -0400, The Wanderer wrote:
> Diego Biurrun wrote:
> 
> >The Wanderer writes:
> >
> >>The Wanderer wrote:
> >>
> >>Revised patches attached; I've got the nagging feeling I've messed
> >>something up, but I can't find anything obvious.
> >
> >This does not apply cleanly anymore, please resend.
> 
> It took a little more work, but here you go. (The recently changed EDL
> code was committed with hardcoded translatable strings...)

It needs to be updated again, the EDL code has been moved out of
mplayer.c. There is also a left over from a conflicting commit.
I couldnt spot anything else that would prevent a commit.
Sorry for the delay :/

> While I'm at it, a minor issue. The copyright string, ("MPlayer "
> VERSION " (C) 2000-2004 MPlayer Team") has one translatable word in it,
> "team"; is it worth moving it to the translation file for that purpose,
> or not? If so, should the entire printed line be moved - in which case
> it would be easier to do it as ("MPlayer %s (C) 2000-2004 MPlayer Team",
> VERSION) - or just part of it (what part?)?

Hmm.. Dunno. Diego ? 

		Attila Kinali




More information about the MPlayer-dev-eng mailing list