[MPlayer-dev-eng] Re: [PATCH] bug in libfaad2 since update to 2.0, ad_faad better error discription

[Diego Biurrun]

adland123 writes:
> > And adland, what happened to the patch you sent for sbr files?  Does
> > it work for you now?
> 
> Patch was negated by later libfaad CVS changes. 
> Because the later CVS versions of libfaad did not have
> the pop/clicks when playing the sbr samples in my testing.
> Assume it can safely be ignored since it is changed in their code.

OK, good to hear.  Then we can scratch this off our list.

> > What is the status of current FAAD CVS?  Were there any important or
> > interesting improvements/speedups?  If yes, it might be worth updating
> > your patch to current CVS.  Somebody else posted an update for
> > libfaad, but I'm afraid this will not contain our portability fixes.
>  
>  The CVS version of July was about same in performance for each
>  sample I had to test with.
>  The bugs that were found in 2.0 also appeared to be gone.
>  I am not the best tester so there may be more undiscovered issues.
>  limited to testing just one platform x86 linux. 
> 
>  Not sure what exactly has been changed since then in the libfaad CVS. 
> 
> > Anyway, adland, don't despair, I'll update libfaad one way or the
> > other soon.
> 
> okay thanks a lot. Dont take my last response as a complaint of any type.

I didn't take it that way, but I could very well understand a certain
amount of frustration after waiting so long to get patches committed.

Diego