[MPlayer-dev-eng] [PATCH] remove obsolete lavcopts mbqmin/max

Diego Biurrun diego at biurrun.de
Fri Sep 10 11:56:03 CEST 2004


Loren Merritt writes:
> 
> --- libmpcodecs/ve_lavc.c~	2004-08-21 12:31:00.000000000 -0700
> +++ libmpcodecs/ve_lavc.c	2004-09-09 21:10:40.000000000 -0700
> @@ -176,8 +176,10 @@
>  	{"vqscale", &lavc_param_vqscale, CONF_TYPE_FLOAT, CONF_RANGE, 0.01, 255.0, NULL},
>  	{"vqmin", &lavc_param_vqmin, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
>  	{"vqmax", &lavc_param_vqmax, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
> +#if LIBAVCODEC_BUILD <= 4683
>  	{"mbqmin", &lavc_param_mb_qmin, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
>  	{"mbqmax", &lavc_param_mb_qmax, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
> +#endif
>  	{"lmin", &lavc_param_lmin, CONF_TYPE_FLOAT, CONF_RANGE, 0.01, 255.0, NULL},
>  	{"lmax", &lavc_param_lmax, CONF_TYPE_FLOAT, CONF_RANGE, 0.01, 255.0, NULL},
>  	{"vqdiff", &lavc_param_vqdiff, CONF_TYPE_INT, CONF_RANGE, 1, 31, NULL},
> @@ -353,7 +355,7 @@
>  #endif
>      lavc_venc_context->qmin= lavc_param_vqmin;
>      lavc_venc_context->qmax= lavc_param_vqmax;
> -#if LIBAVCODEC_BUILD >= 4646
> +#if LIBAVCODEC_BUILD >= 4646 && LIBAVCODEC_BUILD <= 4683
>      lavc_venc_context->mb_qmin= lavc_param_mb_qmin;
>      lavc_venc_context->mb_qmax= lavc_param_mb_qmax;
>  #endif

I think it's pointless to keep this kind of backwards compatibility,
MPlayer is built with CVS libavcodec anyway.  I currently have

#define LIBAVCODEC_BUILD       4721

in my libavcodec tree.

Michael, what do you think?

Diego




More information about the MPlayer-dev-eng mailing list