[MPlayer-dev-eng] [PATCH] improving MP3 detection

[Diego Biurrun]

The Wanderer writes:
> Reimar Döffinger wrote:
> 
> > -  mp_msg(MSGT_DEMUX,MSGL_V,"demux_audio: audio data 0x%X - 0x%X  \n",demuxer->movi_start,demuxer->movi_end);
> > +  mp_msg(MSGT_DEMUX,MSGL_V,"demux_audio: audio data 0x%X - 0x%X  \n",(int)demuxer->movi_start,(int)demuxer->movi_end);
> 
> My only objection to this patch, as the one who will most likely wind up
> correcting the matter, is that it adds translatable strings as hardcoded
> rather than putting them in the translation file. AFAIK MSGL_V does need
> to be translated...? If not, many of the strings I moved should probably
> have been left alone, and I'd like to know about it to avoid unnecessary
> work in the future.

>From mp_msg.h:

// verbosity elevel:

// stuff from level MSGL_FATAL-MSGL_HINT should be translated.

#define MSGL_FATAL 0  // will exit/abort
#define MSGL_ERR 1    // continues
#define MSGL_WARN 2   // only warning
#define MSGL_HINT 3   // short help message
#define MSGL_INFO 4   // -quiet
#define MSGL_STATUS 5 // v=0
#define MSGL_V 6      // v=1
#define MSGL_DBG2 7   // v=2
#define MSGL_DBG3 8   // v=3
#define MSGL_DBG4 9   // v=4

So no need to translate verbose level messages.

Diego