[MPlayer-dev-eng] Re: [PATCH] bug in libfaad2 since update to 2.0, ad_faad better error discription

[Diego Biurrun]

adland123 writes:
> Reimar Döffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:
> 
> > since the update, http://www.pikebo.cz/~dzon/sample.nsv doesn't play 
> > audio anymore.
> > The attached patch fixes, although I do not know what exactly it does.
> 
> There were some issues in the 2.0 release of libfaad as we found out later.
> Just a note this bug may have been fixed in the CVS version of libfaad.

Yes, it is fixed.

> I posted a patch of the libfaad CVS code 2 months or so back
> which fixed a playback issue reported at that time.
> 
> It is not containing any of the latest CVS changes in last 2 months time however.
> 
> we also have added some small patches to allow compilation on 
> multiple platforms like Cygwin.

I sent those changes to Dan Christiansen, he is an FAAD dev, so far he
does not seem to have merged the changes, however.  What happened,
Dan?

And adland, what happened to the patch you sent for sbr files?  Does
it work for you now?

I was hoping we could sync to an FAAD version that already contained
our changes.  I don't think it's worth the wait, though, and we have
real bugs to fix.

What is the status of current FAAD CVS?  Were there any important or
interesting improvements/speedups?  If yes, it might be worth updating
your patch to current CVS.  Somebody else posted an update for
libfaad, but I'm afraid this will not contain our portability fixes.

Anyway, adland, don't despair, I'll update libfaad one way or the
other soon.

Diego