[MPlayer-dev-eng] Re: [PATCH] edl now works when seeking, more

Attila Kinali attila at kinali.ch
Mon Sep 6 15:25:50 CEST 2004


On Sat, Sep 04, 2004 at 04:57:46AM -0400, Reynaldo H. Verdejo Pinochet wrote:
    

> --- edl.c	2004-08-27 20:46:05.000000000 -0400
> +++ ../my_main/edl.c	2004-09-04 04:18:36.000000000 -0400
> @@ -8,6 +8,12 @@
>  
>  int edl_check_mode(void)
>  {
> +/** Makes sure that edl has been called
> + * in one of his operating modes but not both
> + * we cant do -edl and -edlout at the same time
> + * so we return EDL_ERROR when this happens.
> + * 1 otherwise.
> + */

If you move the comments before the function then they work as expected
and you have to document them only once. Also add a description of the
parameters and the return values as described in my draft.

Thanks

				Attila Kinali




More information about the MPlayer-dev-eng mailing list