[MPlayer-dev-eng] [PATCH] ogg subtitle language

[Joey Parrish]

On Mon, Sep 06, 2004 at 09:43:49AM +0200, Moritz Bunkus wrote:
> > At Attila's suggestion, here's a patch to show the subtitle language (if
> > available) on OSD when switching ogg subs.
> 
> Basically this looks fine to me, but I had thought about going a bit
> further. For the sake of usability I'd like to translate both the
> language codes on DVDs and in Matroska files to their English
> names. This can easily be done, and that code already exists on my
> side.

Is that translation table of codes to languages already in MPlayer
somewhere?

> Now what I had thought about is having a general
> demux_get_track_language function and not several 'if (demuxer->type
> ==...)' in main(). That's how it's done for the other demux_* functions.

That would be better, I agree.  I don't have time to implement right
now, though.  If you do the changes to the demux API, I will eventually
get around to making ogg and dvdread conform.  Or you can do it
yourself, I won't be offended.

We should also have a demux_next_sub_track function to avoid the nasty
crap I started in mplayer.c under SUB_SELECT.

--Joey

-- 
"The Hell Law says that Hell is reserved exclusively for them that believe
in it.  Further, the lowest Rung in Hell is reserved for them that believe
in it on the supposition that they'll go there if they don't."
  HBT; The Gospel According to Fred, 3:1