[MPlayer-dev-eng] [PATCH] Fix for --enable-gif bug (bugzilla

[Joey Parrish]

On Sun, Sep 05, 2004 at 02:31:15PM +0300, Ivan Kalvachev wrote:
> Joey Parrish said:
> > On Sat, Sep 04, 2004 at 09:43:37PM -0400, D Richard Felker III wrote:
> >> On Sun, Sep 05, 2004 at 03:02:37AM +0200, Ivo wrote:
> >> > I propose the following patch. Without the patch, ./configure--enable-gif
> >> > never tries to detect which library to use, never sets HAVE_GIF_4 and
> >> never
> >> > sets _ld_gif. This patch does the same as configure does for --enable-dga.
> >
> >> i can tell you right away this won't get accepted, because it violates
> >> mplayer policy. --enable is always supposed to force-enable, not do
> >> auto-detection... not my rule, and i know sometime's it's quirky, but
> >> i still think it makes more sense than autoconf's way.
> >
> > I'm not against it personally, but it is against policy.  I propose that
> > as an alternate solution, you send me weekly private email telling me to
> > get around to fixing the configure checks correctly.  :)
> 
> People don't be such fanatics.
> 
> --enable-gif DOESN"T WORK!!!
> 
> It is a bug and should be fixed.
> 
> If you are scared to apply the patch by yourself, I will do it.

No, it's a known problem, it's my code, and this is not a good fix.

Do not commit this.

--Joey

-- 
"The Hell Law says that Hell is reserved exclusively for them that believe
in it.  Further, the lowest Rung in Hell is reserved for them that believe
in it on the supposition that they'll go there if they don't."
  HBT; The Gospel According to Fred, 3:1