[MPlayer-dev-eng] [PATCH] Startup crash on sparc64

Diego Biurrun diego at biurrun.de
Sat Sep 4 15:38:30 CEST 2004


Reimar Döffinger writes:
> 
> >>>>Did anyone test? Does it fix the problem? Please reply, I really need 
> >>>>some feedback on this!
> >>>
> >>>Apply it, i dont see how it can hurt (unless it does some missalingment
> >>>of other data) and it might fix the problem.
> >>
> >>Ok, I applied.
> > 
> > And reversed again :(
> > 
> > Can you fix your solution so it pleases Rich too ?
> 
> I'd suggest the attached version, but somebody should test if that works 
> for gcc 2.95, as I have no idea where exactly this __attribute__ should 
> be placed...

Rich overlooked a patch sent in by Björn Sandell to fix compilation
with gcc 2.95.3.

Subject: [MPlayer-dev-eng] [PATCH] unbreak m_config.h
Date: Tue, 31 Aug 2004 14:14:11 +0200

Reimar, I'm pasting the patch here for you to apply.

Diego

--- m_config.h	30 Aug 2004 17:36:48 -0000	1.6
+++ m_config.h	31 Aug 2004 07:20:40 -0000
@@ -11,8 +11,8 @@
   int lvl;
   // we have to store other datatypes in this as well,
   // so make sure we get properly aligned addresses
-  __attribute__ ((aligned (8)))
-  unsigned char data[0];
+  unsigned char data[0]
+  __attribute__ ((aligned (8)));
 };
 
 struct m_config_option {




More information about the MPlayer-dev-eng mailing list