[MPlayer-dev-eng] Re: [PATCH] edl now works when seeking, more

[Reynaldo H. Verdejo Pinochet]

On Sat, Aug 28, 2004 at 02:54:50PM +0900, Attila Kinali wrote:
> > +           "Cant use -edl and -edlout at the same time\n");
> > +    mp_msg(MSGT_CPLAYER, MSGL_WARN, "Not using EDL at all!!!\n");
> 
> MSGL_WARN -> MSGL_ERR, fail end exit.
> 
done

[ more  patch code ]

> 
> When is this memory freed again ?
> 

Will do on player_exit and on mencoder_exit.

[ more patch code ]
> > +	       "Error opening file [%s] for writing!\n",
> > +               edl_output_filename);
> 
> MSGL_WARN -> MSGL_ERR, fail end exit.
> 
done
[ more patch code ]
> > +/*
> > + * We Saw a seek, have to rewind the edl operations stak
> > + * and find the next edl action to take care off
> > + */
> 
> Saw -> saw :)
> 
typo! done ;)

[ more patch code ]
> > +                    if (stop <= start)
> > +                    {
> > +                        mp_msg(MSGT_CPLAYER, MSGL_WARN,
> > +                               "Invalid EDL line [%d]: %s", lineCount,
> > +                               line);
> > +                        mp_msg(MSGT_CPLAYER, MSGL_WARN,
> > +                               "Stop time must follow start time. Discarding!\n");
> 
> "Stop time has to be after start time"
> "follow" is not clear in this case.
> 
Ok...
> 
> Other than that, you should add doxygen (doxygen.sf.net) style
> comments to all functions and global variables.
> I'll try to write some docu about this as soon as possible.
> 
Have readed it, will do.

I will send this changes with the big mencoder-with-edl patch, just
giveme a few days
> 
> 			Attila Kinali
Regards

   Reynaldo
   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040904/6a43daf7/attachment.pgp>