[MPlayer-dev-eng] [PATCH] movie_aspect switching at runtime

[Aurelien Jacobs]

On Thu, 2 Sep 2004 10:26:15 -0400
D Richard Felker III <dalias at aerifal.cx> wrote:

> On Fri, Aug 27, 2004 at 01:39:53PM +0200, Aurelien Jacobs wrote:
> > This patch add a new slave command to change the movie_aspect at
> > runtime. Will document it if it's ok.
> > 
> > Aurel
> 
> imo this has to be incorrect... movie aspect handling is much more
> complicated than this and involves the whole filter chain and
> disp_w/disp_h. a patch like this is almost certain to mess things up
> with nontrivial filter chain (i.e. any filters that play with aspect).
> but i'm not positive about that, so if you claim it works please test
> it thoroughly and report back.

Your probably right. This was only meant to be used in a simple
configuration, with almost no filters. But I think this is the
configuration where it's the most usefull. Advanced users setting
up multiple filters probably won't need this.

> anyway manually overriding aspect is usually nonsense...

Huh ! Movies encoded with a bad aspect are unfortunatly quite
common. When basic users are launching such a movie and are
discovering this bad aspect, they are happy to be able to
change this without having to reload mplayer. At least this
feature was reqested by some geexbox users.

Aurel