[MPlayer-dev-eng] [PATCH] Keep audio buffer for OSS
ivan at cacad.com
Wed Sep 1 12:43:28 CEST 2004
D Richard Felker III said:
> On Mon, Aug 02, 2004 at 05:05:36PM +0200, Mikulas Patocka wrote:
>> audio_pause and audio_resume should keep data in audio buffer. However
>> they don't do it for OSS audio driver. This causes problem that if the
>> audio buffer is X seconds large, the movie skips X seconds forward on each
>> pause/unpause operation.
>> This patch fixes it --- it uses OSS trigger function (and falls back to
>> old method if the driver doesn't support it), so that it audio data are
>> being held in the buffer.
> This patch has a major problem!! It makes MPlayer keep the sound
> device open while paused, so you can't just pause the movie/music to
> let another program play audio. VERY BAD!!
Rich I don't want to start an flame war, but you are wrong.
Skiping X seconds mean, that for keeping sync mplayer skips frames
after each pause!!!. I usually got about 12 dropped frames in a row...
(Now I checked it and it seems that frames are not counted as skipped
but there is jump after unpause)
_THIS_ is VERY BAD!!!
Years ago I had talked with arpi about this bug and he found a possible
solution. If I remeber right it hit the CVS, then after some time it was
reverted or disabled. I think it had something to do with bad/partialy
implemented OSS drivers.
On the other side SDL that use OSS don't have this problem...
Wish You Best
p.s. I haven't looked in tha patch. I will do. I will also check what
the solution was and what happend with it...
More information about the MPlayer-dev-eng