[MPlayer-dev-eng] [PATCH] Pause after command
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Oct 31 23:10:58 CET 2004
On Sun, Oct 31, 2004 at 11:25:39PM +0200, Oded Shimon wrote:
> On Sunday 31 October 2004 23:15, Reimar Döffinger wrote:
> > IMHO this is risky because it can cause unpredictable behaviour.
> I don't see how, maybe it does, I know pretty little about MPlayer source..
> saw about 0.1% of it... :)
Has nothing to do with MPlayer source, point is, whether the
mp_input_get_cmd returns NULL or not does not only depend on what the
user does but also e.g. on the scheduler. I think you are trying to find
out whether there is a pause command following that belongs to the
previous command. This is a very ugly way to do it I think.
> > Also, most functions will not work before the stream is unpaused again.
> > What exactly should this do in which cases?
> I don't see how, there is almost an entire main loop inbetween:
ok, so with this patch MPlayer will play only one frame further instead
of two when doing something like "echo -e 'seek 1\npause'", right? I'm
not convinced that that feature is worth adding this - it looks very
much like a hack to me ;-)
Feel free to convince me otherwise, though...
More information about the MPlayer-dev-eng