[MPlayer-dev-eng] [PATCH] fix for -srate bug

D Richard Felker III dalias at aerifal.cx
Wed Oct 20 06:01:31 CEST 2004


On Wed, Oct 20, 2004 at 05:19:58AM +0300, Jan Knutar wrote:
> On Tuesday 19 October 2004 19:07, D Richard Felker III wrote:
> 
> > libsamplerate is bloated, poor code. the resampler in lavc is much
> > faster and can do the same stuff and probably more than your precious
> > libsamplerate. can we please let this rest? dependencies on new poorly
> > written libs are not welcome in mplayer.
> 
> Aren't most library dependencies in MPlayer made optional anyway? I like it
> that way...
> 
> Anyway, there's -sws, so why not -arm (audio resample method), or perhaps more
> apropriately as a suboption to -af resample, wouldn't that be somewhat acceptable
> for inclusion, making its presence totally optional?

notice the -sws options _all_ use the same swscaler module which is
very configurable. similarly the -arm (actually idiotic, this should
be a filter-local param, not a global param, same for vf_scale...) can
control which type of filtering the lavc resampler is configured to
do. there is _no_excuse_ for including support for a different totally
unoptimized resampler that just duplicates functionality of lavc...

rich




More information about the MPlayer-dev-eng mailing list