[MPlayer-dev-eng] [PATCH] Moving help_mp.h generation to makefile

Diego Biurrun diego at biurrun.de
Tue Oct 12 13:46:57 CEST 2004


Torinthiel writes:
> 
> Right now the help_mp.h file is generated only every time ./configure is run.
> This has an ill effect that, if one uses any translation instead of the English messages and
> someone adds a new message which is (yet) missing in translation, the
> compilation is broken until he regenerates the help file either manually
> or by re-running ./configure (which wouldn't be necessary otherwise).
> This patch addresses the issue by moving help_mp.h generation to
> Makefile.
> There is one issue with it, help_mp.h has to be generated really fast,
> but I'm not sure if making everything depend on it just like version.h
> is a good idea. dep is made dependent on help_mp.h because otherwise
> make dep fails.
> Any comments?

It looks correct to me.  What's the deal with help_mp.h needing to be
generated fast?

> +	@echo '// untranslated messages from the english master-file:' >> help_mp.h

While you're at it, why not fix the typos.. "English master file".

Diego




More information about the MPlayer-dev-eng mailing list