[MPlayer-dev-eng] [PATCH] subtitle reload, slave mode

[Reimar Döffinger]

Hi,

>  #define MP_CMD_SWITCH_VSYNC 54
>  #define MP_CMD_SWITCH_RATIO 55
> +#define MP_CMD_SUB_RELOAD 56
>  

This clashes with my frame-stepping patch. Whoever applies should make 
sure to put a valid number here...

> +/// \brief reloads the subtitle file during playback - only used in slave mode
> +/// \param search the absolute path to the old subtitle file, which needs to be updated
> +/// \param replace the absolute path to the new subtitle file

I would prefer the /** style doxygen comment for block comments. What do 
the others think? Should we add something about this to 
DOCS/tech/code-documentation.txt to get a more consistent style?

> +void reload_subtitles_file(char *search, char *replace)
> +{
> +    sub_data *subd, *sub_search;
> +    int counter;
> +
> +    if (filename == NULL) return;

Huh? What is this here for?

> +    case MP_CMD_SUB_RELOAD:
> +    {
> +#ifdef USE_SUB
> +      if (sh_video) {
> +        reload_subtitles_file(cmd->args[0].v.s, cmd->args[1].v.s);
> +	vo_osd_changed(OSDTYPE_SUBTITLE);
> +      }
> +#endif
> +    } break;

You're mixing tabs and spaces for indentation here, please fix.

Greetings,
Reimar Döffinger