[MPlayer-dev-eng] [PATCH] corrected lpcm support

[Joey Parrish]

On Sun, Oct 10, 2004 at 01:10:42PM -0500, Joey Parrish wrote:
> On Sun, Oct 10, 2004 at 06:53:09PM +0200, Reimar Döffinger wrote:
> > >>>I hope the attached patch to implement correct LPCM support. Please 
> > >>>check, as it is really a quick "hack", and certainly not as fast as I'd 
> > >>>wish it to be...
> > >>
> > >>applied. Would be nice if somebody could test...
> > >
> > >I'm willing to, but according to the manpage, do lpcm correspond only to
> > >"quick and dirty" mastered DVDs?
> > 
> > LPCM is DVD-Audio afaik...
> > 
> > >I, unfortunately have only ac3 and dts DVDs...
> > >Would muxing pcm and mpeg4 into a mkv or ogm do the trick?
> > 
> > No, certainly not. LPCM != PCM, otherwise I wouldn't hav had to 
> > implement anything...
> 
> I can test this, and will do so soon.

Well, the only LPCM sample I have is 16-bit, which doesn't help test
this 20/24 bit patch.  Furthermore, the 16 bit sample I have doesn't
play correctly.  I get nothing but static.  My DVD player plays it fine.
VLC plays it fine.  And I examined the VLC decoder side-by-side with the
MPlayer decoder and could tell no difference in the interpretation of
the LPCM header for 16 bit samples.

--Joey

-- 
"I know Kung Fu." --Darth Vader