[MPlayer-dev-eng] [PATCH] Cyberblade VidiX driver TVOUT

Sascha Sommer saschasommer at freenet.de
Sun Oct 10 22:55:40 CEST 2004


On Saturday 09 October 2004 18:43, Benjamin Zores wrote:
> On Sat, 9 Oct 2004 19:12:48 +0000
>
> Sascha Sommer <saschasommer at freenet.de> wrote:
> > >-	disable_app_io();
> >
> > This think this is bad, if you enable it you also have to disable it, no?
>
> sorry, this patch has been done more than a year ago and I never checked it
> again. you're totally right, first it's useless, then any enabled thing
> should be disabled. so here's an update of the patch, related to TVOut fix
> only.
>
> > The other question is why does it portio instead of mmio?
>
> don't know, I'm not author of the driver.
>
> > Is there really a cache issues as mentioned on the top of the file?
>
> don't know either, haven't tested yet.
> My patch is only concerning the TVOut problem from now.
>

Applied.

Sascha




More information about the MPlayer-dev-eng mailing list