[MPlayer-dev-eng] [PATCH] make --disable-mp3lib etc working

Nico Sabbi nsabbi at tiscali.it
Sun Oct 10 12:10:25 CEST 2004


Reimar Döffinger wrote:

> Hi,
>
>>>>> I'm lazy to check by myself so I will ask here;)
>>>>> does the mpeg_ts demuxer call liba52 function, and is this the 
>>>>> reason to
>>>>> #ifdef it?
>>>>
>>>>
>>>> yes, during the probing phase I call a52_syncinfo() to check if a 
>>>> portion of
>>>> bytes is a valid a52 frame.
>>>
>>>
>>> So, is the #ifdef acceptable? Does libdts also provide this 
>>> function? Should it be changed to
>>> #if USE_LIBA52 || USE_LIBDTS ?
>>>
>> the #ifdef is unavoidable: if liba52 isn't compiled in I can't use it.
>> libdts doesn't have anything to do with it. I can insert in 
>> demux_ts() a stripped down
>> version of a52_syncinfo() just to check the framesize. OK?
>
>
> You have to know what makes most sense, I don't know the code, I just 
> fixed compilation ;-)
>
> Greetings,
> Reimar Döffinger



the attached patch will solve this issue for good, but it adds a small 
code redundancy.
I'll commit tonight it no one objects

    Nico
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.tsa52
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041010/9696bb74/attachment.txt>


More information about the MPlayer-dev-eng mailing list