[MPlayer-dev-eng] patch: small bug in alsa driver

Ed Wildgoose lists at wildgooses.com
Wed Oct 6 16:44:28 CEST 2004


Since there seems to be some activity on the alsa driver: Please have a 
look at the following and apply to CVS.

It's only a small gremlin, but the issue is that if the buffersize is 
NOT set manually using options, then "ao_data.buffersize = -1", and so 
we go through the switch statement and reset the defaults.  This 
overrides what we set at the top of the module and hence may be 
confusing to maintainers having to change values in two different places

Ed W


--- libao2/ao_alsa.c.orig       2004-10-06 15:40:09.769401761 +0100
+++ libao2/ao_alsa.c    2004-10-06 15:40:25.518924732 +0100
@@ -491,7 +491,7 @@
     }

     //sets buff/chunksize if its set manually
-    if (ao_data.buffersize) {
+    if (ao_data.buffersize > 0) {
       switch (ao_data.buffersize)
        {
        case 1:




More information about the MPlayer-dev-eng mailing list