[MPlayer-dev-eng] [PATCH] ignore iconv error in subreader

Song Du freewizard at gmail.com
Sat Nov 20 11:21:26 CET 2004


It's really not so user-friendly if any small mistakes in iconv or the
subtitle will cause no sub loaded at all.
Unfortunately, the situations can both be true bcz:
1 the gb(Chinese) charmap in kernel has tiny bugs, 
2 some sub file(.srt) contains illegal character when saved by
translaters under Windows.

so i suggest to continue loading sub even an iconv err was detected.
Ofcoz if a wrong -subcp parameter is given user will get garbage, but
that's acceptable bcz the user may understand it's cp error not the
sub itself then change the parameter.

the patch has only 1 line changed and 2 line removed, nothing will be
broken i guess.


-- 
freewizard (at) gmail.com 
http://blog.tsing.org/freewizard/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: subreader.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041120/f15af39f/attachment.asc>


More information about the MPlayer-dev-eng mailing list