[MPlayer-dev-eng] [PATCH] -ao pcm suboptions

[The Wanderer]

Olivier Rolland wrote:

> Le 19.11.2004 11:59:21, Diego Biurrun a écrit :
> 
>> However, you should remove the old option descriptions from the man
>> page as well as adding the suboptions.
> 
> Done.

> +.IPs waveheader
> +Include wave header.
> +.IPs nowaveheader
> +Don't include wave header.
> +Used for raw PCM.

Shouldn't whichever of these is default (waveheader, I believe) be
marked that way?

> +				pcm_filename = strndup (&ao_subdevice[parse_pos], file_len);
> +				parse_pos += file_len;
> +				fprintf(stderr, "%s\n", pcm_filename);

Instead of fprintf(stderr, ...), shouldn't this use mp_msg(MSGL_CPLAYER,
...) or similar?

(I initially signed up as an "incoming printf" watchdog... I haven't had
much to do in that respect, but I do try to keep an eye out.)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.